test: add unit tests for AlertDeriver.get_threshold/get_threshold_async - #312
Open
acailic wants to merge 1 commit into
Open
test: add unit tests for AlertDeriver.get_threshold/get_threshold_async#312acailic wants to merge 1 commit into
acailic wants to merge 1 commit into
Conversation
collector/alerts/base.py sat at 27.78% coverage with no direct tests for the sync/async threshold-resolution logic. Adds 9 tests covering: no policy getter, sync getter (enabled/disabled/None), and async getter (awaited vs. sync-context fallback). File now at 100% coverage. Fixes #311 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collector/alerts/base.py(AlertDeriver) sat at 27.78% coverage —get_thresholdandget_threshold_asynchad no direct unit teststests/alerts/test_alert_deriver_base.pywith 9 tests via a minimal concrete subclass, covering: no policy getter, sync policy getter (enabled / disabled / returns None), and async policy getter (properly awaited inget_threshold_async, falls back to default when called from the syncget_threshold)Fixes #311
Test plan
ruff check .— cleanpytest tests/alerts/test_alert_deriver_base.py -v— 9/9 passpytest --cov=collector.alerts.base— 100% coverage, no warningspytest -q— 3162 passed (3153 prior + 9 new), 19 skipped (pre-existing, missing optional deps), 0 failures🤖 Generated with Amplifier