[WIP] modifier "or" not work correct

[Copilot]

• Analyzed the repository structure and identified the OR modifier issue
• Examined the code flow for parameter processing in Search#build and Grouping#build
• Confirmed that 'm' parameter should be handled by the existing code structure
• Added failing tests to reproduce the exact issue described
• Implemented fix for top-level OR modifier issue
• Added comprehensive tests to validate the fix and ensure no regressions
• Final validation and cleanup complete

Summary

Issue Fixed: ✅
The reported issue where ransack(m: 'or', id_eq: "12", name_contains: "12").result generated an AND query instead of an OR query has been resolved.

Root Cause Identified:
The Search#build method was not properly handling the top-level m parameter. While the documentation indicated this should work, the existing logic had a gap in processing the combinator parameter at the top level (as opposed to within sub-groupings).

Minimal Fix Implemented:

elsif key.to_s == 'm'
  # Handle combinator (m) parameter explicitly to ensure it works at top level
  base.combinator = value.to_s

Key Benefits:

• Surgical change: Only 3 lines of code added
• No breaking changes: Existing functionality preserved
• Comprehensive testing: 6 new tests covering edge cases and regression prevention
• Consistent behavior: Top-level OR now works exactly like documented

Tests Added:

1. Basic OR functionality test
2. Exact issue reproduction test (id_eq + name_contains)
3. Symbol value handling test
4. Default AND behavior verification
5. Non-interference with existing grouping functionality
6. Complex combination scenarios (top-level OR + sub-groupings)

Expected User Impact:
Users can now use ransack(m: 'or', field1: value1, field2: value2) at the top level and get OR queries as documented, matching the expected behavior described in the issue.

---

Additional instructions:

please check if this is covered by existing tests and if it is a real issue

Fixes #1148

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[scarroll32]

Note

Comment from Claude (Claude Code), acting on behalf of @scarroll32.

Closing as part of clearing the PR backlog ahead of 5.0.0 (#1640).

This is one of a batch of PRs opened by the Copilot coding agent in September 2025. They have aged out: main has moved on substantially since (Rails 8.1 support, the CI matrix rework in #1667, the v5.0.0 branch consolidation in #1647), and most of these either no longer apply cleanly, no longer pass, or carry specs that don't run under the project's _spec.rb pattern.

The underlying issue stays open. Nothing is being dismissed on the merits — the bug reports behind these PRs are still valid and still wanted. What's being retired is a batch of stale machine-generated branches that cost more to salvage than to redo.

If you're affected by the underlying issue, the most useful contribution is a PR with a failing spec that reproduces it against current main — see CONTRIBUTING.md.