Skip to content

espressif/boards/lilygo_tdongle_s3/board.c: flip brightness sense#11092

Merged
dhalbert merged 1 commit into
adafruit:mainfrom
dhalbert:lilyo-tdongle-s3-brightness-flip
Jul 8, 2026
Merged

espressif/boards/lilygo_tdongle_s3/board.c: flip brightness sense#11092
dhalbert merged 1 commit into
adafruit:mainfrom
dhalbert:lilyo-tdongle-s3-brightness-flip

Conversation

@dhalbert

@dhalbert dhalbert commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

@Mandred @freemansoft Could you check the artifact from this PR? I don't have this board to test. Thanks.

@tannewt tannewt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine. Not merging until we hear from someone who tested it.

@freemansoft

Copy link
Copy Markdown

How do I test this if it isn't merged? I forgot how this works. Are there build images to download?

@todbot

todbot commented Jul 8, 2026

Copy link
Copy Markdown

Short answer: download the lilygo_tdongle_s3 file here https://github.com/adafruit/circuitpython/actions/runs/28718009010#artifacts

Longer answer: any time there is a PR (like there is here, 6b3ff04), click on it and go to the "Checks" tab. From there, click on the "Build CI" check and you'll get a new page with an "Artifacts" heading at the top. In this case there are 7 artifacts. If you click on that "7" you'll be scrolled down to the bottom of the page where the various artifacts for the "Build CI" check. One of those artifacts is the built firmware for your board as a .zip file. Download that, unzip it, and you should find a .UF2 or .BIN file.

@freemansoft

freemansoft commented Jul 8, 2026

Copy link
Copy Markdown

LGTM

Build artifacts validated: Passed

Steps

  1. Verified version prior to test reported Adafruit CircuitPython 10.0.3-4-gc9465b3454 on 2026-01-06; LILYGO T-Dongle S3 with ESP32S3
  2. Downloaded Artifact https://github.com/adafruit/circuitpython/actions/runs/28718009010#artifacts
  3. Flashed the new .bin bootloader in the archive using https://adafruit.github.io/Adafruit_WebSerial_ESPTool/ and the bin file from the zip archive build artifact. Erased device using the tool prior to installing the new bootloader
  4. On startup the boot message shows version Adafruit CircuitPython 10.3.0-alpha.3-11-g1868df28ab on 2026-07-04; LILYGO T-Dongle S3 with ESP32S3

Results

  • REPL now visible on built-in display.
  • "Hello World!" appears on display
  • All files were erased as part of the installation, so no left over artifacts on the drive to taint the tests.

Note:
I thought the bin file was a bootloader and didn't realize it was circuitpython. I thought I'd have to drop the uf2 into a directory or something after using the bin file.

@dhalbert

dhalbert commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

@freemansoft Thank you for testing! I linked the artifact in the OP but it was subtle. Thanks @todbot for explaining where to find them.

@dhalbert dhalbert merged commit 484029d into adafruit:main Jul 8, 2026
17 checks passed
@dhalbert dhalbert deleted the lilyo-tdongle-s3-brightness-flip branch July 8, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T-Dongle S3 Display Brightness is inverted

4 participants