Repository navigation
feat(acp-model): add v2 agent-owned terminal display surface - #134
Merged
Merged
Conversation
Collaborator
Author
|
Based on #133 , rebase and merge only after it |
EugeneTheDev
force-pushed
the
eugenethedev/v2-read-only-terminal
branch
from
September 18, 2026 13:14
6e867cf to
36376c8
Compare
Ololoshechkin
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP v2 removes the client-side
terminal/*execution methods (already the case in this SDK) but replaces them with an agent-owned, display-only terminal model.That replacement surface was missing: incoming
terminaltool-call content andterminal_update/terminal_output_chunknotifications decoded toUnknown.Conversions: v1 and v2 terminal content deliberately do not cross versions — the ownership models are incompatible.
ToolCallContent.Terminalmaps tonullintoV1OrNull,and both new session updates throw
ProtocolConversionExceptioninSessionUpdate.toV1(), asnotice/compaction already do.Two comments claiming the v2
terminalvariant was removed were corrected to say it was redefined.Details: https://agentclientprotocol.com/rfds/v2/terminal-output#v2-terminal-output