Skip to content

feat(acp-model): add v2 agent-owned terminal display surface - #134

Merged
EugeneTheDev merged 1 commit into
masterfrom
eugenethedev/v2-read-only-terminal
Sep 22, 2026
Merged

EugeneTheDev merged 1 commit into
masterfrom
eugenethedev/v2-read-only-terminal

Conversation

@EugeneTheDev

@EugeneTheDev EugeneTheDev commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

ACP v2 removes the client-side terminal/* execution methods (already the case in this SDK) but replaces them with an agent-owned, display-only terminal model.
That replacement surface was missing: incoming terminal tool-call content and terminal_update / terminal_output_chunk notifications decoded to Unknown.

Conversions: v1 and v2 terminal content deliberately do not cross versions — the ownership models are incompatible. ToolCallContent.Terminal maps to null in toV1OrNull,
and both new session updates throw ProtocolConversionException in SessionUpdate.toV1(), as notice/compaction already do.
Two comments claiming the v2 terminal variant was removed were corrected to say it was redefined.

Details: https://agentclientprotocol.com/rfds/v2/terminal-output#v2-terminal-output

@EugeneTheDev
EugeneTheDev requested a review from Rizzen September 17, 2026 15:44
@EugeneTheDev

Copy link
Copy Markdown
Collaborator Author

Based on #133 , rebase and merge only after it

@EugeneTheDev
EugeneTheDev force-pushed the eugenethedev/v2-read-only-terminal branch from 6e867cf to 36376c8 Compare September 18, 2026 13:14
@EugeneTheDev
EugeneTheDev merged commit a751804 into master Sep 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants