Repository navigation
feat(v2): make prompt response an insertion receipt (JUNIE-5706) - #142
Merged
EugeneTheDev merged 5 commits intoOct 12, 2026
Merged
Conversation
EugeneTheDev
self-requested a review
October 8, 2026 13:57
EugeneTheDev
requested changes
Oct 8, 2026
Collaborator
There was a problem hiding this comment.
My major concern here is that you worked around the existing RequestOutcome and created your own setRespondingRequestHandler, which relies on implicit coroutine context variables (something I'm strongly against here). It also introduces a number of bugs, mostly concurrency-related, which the existing implementation using RequestOutcome didn't have.
I also think the number of tests can be reduced to leave only the essential ones.
wayfarer-rus
force-pushed
the
aefimov/feat/JUNIE-5706-v2-prompt-message-id
branch
from
October 9, 2026 08:20
863703e to
abf0f75
Compare
Align v2 with ACP schema tag schema-v2.0.0-alpha.7. - PromptResponse carries required messageId of the inserted user message - agent replies after first user_message/user_message_chunk update, via new internal Protocol.setRespondingRequestHandler - failure, completion or cancellation before insertion -> JSON-RPC error, no idle update; after insertion turn-closing rules unchanged - ClientSession.prompt() returns the receipt MessageId - DiffPatch wire key diff -> text (alpha.3) - add ToolCallUpdate.name (alpha.4) - add availableCommands to session new/resume/fork responses, filled from new AgentSession.availableCommands (alpha.6) Breaking for v2 agents: a prompt flow that never emits a user message fails every prompt. JVM name of ClientSession.prompt becomes prompt-z2_y7hQ (MessageId value class). Co-authored-by: Junie <junie@jetbrains.com>
Remove complexity found in an over-engineering review of the insertion receipt change. Behavior is unchanged, except as noted below. - Agent: drop the separate "ended before insertion" check. The responding request handler already answers a handler that returns without a reply with -32603. Merge the three catch blocks of runPrompt into one. - Protocol: drop the unreachable try/catch after respond. Its only caller already handles every failure after insertion. - Model: share the skip-invalid-item loop as JsonArray.decodeSkippingInvalid. Send an empty availableCommands list as [], the same as configOptions. Schema v2.0.0-alpha.7 treats an omitted and an empty list the same. - Tests: share turnUpdates and insertedUserMessage in acp-ktor-test utils.kt, reuse scriptedV2Support and sessionUpdate() in AgentTest, and remove repeated assertions in SessionResponsesTest. Co-authored-by: Junie <junie@jetbrains.com>
Use RequestOutcome for the insertion receipt, buffered update delivery, and collector cleanup. Remove setRespondingRequestHandler and the response slot carried through coroutine context. Reject cancellation before insertion with -32800. Discard buffered updates on pre-insertion failure or rejected receipt delivery. Keep the prompt Flow signature and avoid suspending user flows on batch reply completion. Cover batch locking, cancellation, callback errors, and rejected receipts. Remove obsolete responding-handler tests and align delivery-order documentation. Co-authored-by: Junie <junie@jetbrains.com>
wayfarer-rus
force-pushed
the
aefimov/feat/JUNIE-5706-v2-prompt-message-id
branch
from
October 9, 2026 08:29
abf0f75 to
f026a78
Compare
EugeneTheDev
requested changes
Oct 12, 2026
Collaborator
|
nit: Also, there are now 5 new v2 tests in AgentTest plus a new PromptReceiptTest with 4 tests, and the new class has its own FrameTransport/agent harness. Some scenarios overlap: "ends before inserting" vs failedInsertionDiscardsUpdates…, and "local cancellation fails a prompt before insertion" vs cancelBeforeInsertion…. Could the receipt tests live in one place with one harness, keeping one test per behavior? |
…y over the wire and wait for the first user message asyncronously instead
EugeneTheDev
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session/promptnow answers with an insertion receipt.PromptResponsehas a requiredmessageId, the id of the inserted user message.AgentSession.prompt()flow and replies tosession/promptafter the firstuser_messageoruser_message_chunkupdate.ClientSession.prompt()returns the receiptMessageId.DiffPatchuses the"text"wire key in place of"diff"(alpha.3). The Kotlin property name does not change.ToolCallUpdate.namepatch field (alpha.4).availableCommandson the V2 new, resume, and fork session responses (alpha.6), filled from the newAgentSession.availableCommands. An empty list is sent as[].null, a non-array value, and invalid items decode tolerantly.acp-model.apiandacp.api.Breaking changes (V2,
@UnstableApi)PromptResponserequiresmessageId.ClientSession.prompt()returnsMessageIdin place ofUnit. BecauseMessageIdis a value class, its JVM name is nowprompt-z2_y7hQ.ToolCallUpdatehas a new constructor parameter aftertitle. Positional callers must use named arguments.Protocol source and scope
schema-v2.0.0-alpha.7.errorstop reason, so a failure after insertion keepsidlewith anullstop reason.RequestOutcome.onCompletionhas no production user now. Its removal is a separate follow-up.