Repository navigation
fix: route session/update racing with a reaped holder to the global handler (IJAI-2705) - #145
Merged
Merged
Conversation
…andler (IJAI-2705)
Rizzen
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session/updatecan find a speculative session holder just beforewithInitializingSessionreaps it, then queue into it afterwards.handleOrQueueawaited the failed session and threwAcpExpectedError: Session … not found, which Protocol logged at SEVERE.handleOrQueuenow reports such an update as undelivered, and the handler sends it toglobalSessionUpdateHandler(or drops it at debug level).failAndDrainQueuecloses the channel before draining, so an update can't be queued after the drain and lost. The holder fails only after the drain, so late updates come after the queued ones.ClientSessionHoldermoved to its owninternalclass to be testable. No public API change.Tests
ClientSessionHolderTestdrives both states deterministically withrunTest. Both tests fail on the old code with the ticket's error.YouTrack: IJAI-2705