Skip to content

Guard node_graph import on remote - #79

Merged
edan-bainglass merged 3 commits into
aiidateam:mainfrom
edan-bainglass:bug-fix
Jun 2, 2026
Merged

Guard node_graph import on remote#79
edan-bainglass merged 3 commits into
aiidateam:mainfrom
edan-bainglass:bug-fix

Conversation

@edan-bainglass

Copy link
Copy Markdown
Member

#66 introduced a bug by requiring node_graph on the remote machine to coerce inputs when inputs_spec is defined. Here we make the import best-effort, notifying the user if the dependency is missing with recommendation of how to install it.

machine to coerce inputs when `inputs_spec` is defined. Here we
make the import best-effort, notifying the user if the dependency
is missing with recommendation of how to install it.
@edan-bainglass

edan-bainglass commented May 20, 2026

Copy link
Copy Markdown
Member Author

@GeigerJ2 Xing reported the bug this morning. This PR is a bandaid! There is likely a more robust approach to this feature, but I would need to understand the codebase a bit more before doing so.

I propose a coding week in the mountains dedicated to node-graph + aiida-pythonjob + aiida-workgraph. Ideally June 22-26 (if not earlier, but may be tricky), before PASC. Pinging @giovannipizzi 🙂

@GeigerJ2

Copy link
Copy Markdown

@GeigerJ2 Xing reported the bug this morning. This PR is a bandaid! There is likely a more robust approach to this feature, but I would need to understand the codebase a bit more before doing so.

I will have a look, as well. Thanks for the ping!

I propose a coding week in the mountains dedicated to node-graph + aiida-pythonjob + aiida-workgraph. Ideally June 22-26 (if not earlier, but may be tricky), before PASC. Pinging @giovannipizzi 🙂

Yes, totally agree! I've been meaning to really dedicate some meaningful time to this, but never got around to doing so... we should discuss / plan a coding week on it ASAP. WG needs to be out and stable, also, for the tutorial.

@codecov-commenter

codecov-commenter commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.42%. Comparing base (4a4264d) to head (5bfdebd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   89.87%   89.42%   -0.46%     
==========================================
  Files          22       22              
  Lines        1324     1324              
==========================================
- Hits         1190     1184       -6     
- Misses        134      140       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GeigerJ2 GeigerJ2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nitpick, to use the parent class ImportError over ModuleNotFoundError.

Comment thread src/aiida_pythonjob/calculations/utils.py Outdated
See PR comment for details
@edan-bainglass
edan-bainglass merged commit b802e7e into aiidateam:main Jun 2, 2026
6 checks passed
@edan-bainglass
edan-bainglass deleted the bug-fix branch June 28, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants