Guard node_graph import on remote - #79
Conversation
machine to coerce inputs when `inputs_spec` is defined. Here we make the import best-effort, notifying the user if the dependency is missing with recommendation of how to install it.
|
@GeigerJ2 Xing reported the bug this morning. This PR is a bandaid! There is likely a more robust approach to this feature, but I would need to understand the codebase a bit more before doing so. I propose a coding week in the mountains dedicated to node-graph + aiida-pythonjob + aiida-workgraph. Ideally June 22-26 (if not earlier, but may be tricky), before PASC. Pinging @giovannipizzi 🙂 |
I will have a look, as well. Thanks for the ping!
Yes, totally agree! I've been meaning to really dedicate some meaningful time to this, but never got around to doing so... we should discuss / plan a coding week on it ASAP. WG needs to be out and stable, also, for the tutorial. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 89.87% 89.42% -0.46%
==========================================
Files 22 22
Lines 1324 1324
==========================================
- Hits 1190 1184 -6
- Misses 134 140 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
See PR comment for details
#66 introduced a bug by requiring
node_graphon the remote machine to coerce inputs wheninputs_specis defined. Here we make the import best-effort, notifying the user if the dependency is missing with recommendation of how to install it.