Repository navigation
fix(rstar): backpropagate rewards from evaluated rollout nodes - #344
Merged
codelion merged 1 commit intoOct 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R* attaches the simulation steps to the search tree, but backpropagates only from the node where simulation started. The added descendants retain zero visits and zero value. Since
trajectory_scorereads the last node, completed trajectories can all score zero even when their evaluated rewards differ.Return the evaluated node alongside the simulation reward and backpropagate from it in both the synchronous and asynchronous search. Each rollout still updates the root once, including when the simulation depth is zero.
Validation: 9 tests and 2 subtests passed with
python -m pytest tests/test_rstar_backpropagation.py tests/test_conversation_logging_approaches.py -q. The regressions reproduce unscored terminal nodes in both paths before the fix; concurrent rollouts also check that the higher-reward trajectory is selected. All provider calls are mocked. Ruff passed for the new tests, andgit diff --checkpassed.