Fix CI#33639
Merged
Merged
Conversation
Updates the regular expressions in server-routes-preload-links.ts to allow hyphens in the generated file hashes (changing [a-zA-Z0-9_]{8} to [a-zA-Z0-9_-]{8}).
This ensures that the test correctly identifies modulepreload links when the hash contains a hyphen, preventing failures due to overly strict matching.
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the regular expression used to strip hashes from chunk names in chunk-optimizer.ts from /-[a-zA-Z0-9]{8}$/ to /-[\w-]{8}$/, along with updating the corresponding E2E tests. However, the feedback correctly points out that using [\w-] is highly prone to false positives because it matches hyphens and underscores. This could result in stripping descriptive parts of chunk names (e.g., changing home-lazy-mod to home), leading to potential naming collisions or loss of descriptive names in production. It is recommended to revert to the more restrictive alphanumeric pattern.
crisbeto
approved these changes
Jul 23, 2026
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
allow-hyphens
branch
from
July 23, 2026 08:49
1462eac to
c6ce93e
Compare
…hunk hash in chunk optimizer
Updates the regular expression in chunkFileNames from /-[a-zA-Z0-9]{8}$/ to /-[a-zA-Z0-9_-]{8}$/ to properly strip esbuild intermediate chunk hashes containing hyphens or underscores before applying Rolldown/Rollup chunk hashes.
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.