refactor(core): remove temporary locationServiceMapLayer constant#35052
Closed
Robin1987China wants to merge 1 commit into
Closed
refactor(core): remove temporary locationServiceMapLayer constant#35052Robin1987China wants to merge 1 commit into
Robin1987China wants to merge 1 commit into
Conversation
Robin1987China
force-pushed
the
deprecate-location-service-map-layer
branch
2 times, most recently
from
b77ff1b to
e30e0b4
Compare
All call sites migrated to buildLocationServiceMap() factory. The constant was marked 'temporary for backwards compatibility' and its usage in server.ts was already migrated upstream.
Robin1987China
force-pushed
the
deprecate-location-service-map-layer
branch
from
e30e0b4 to
88ff1cf
Compare
Contributor
Author
|
Closing in favor of #36204, which retargets this change to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A
Type of change
What does this PR do?
Remove the temporary
locationServiceMapLayersingleton frompackages/core/src/location-services.ts. It was marked// This is temporary for backwards compatibilityand wrapsbuildLocationServiceMap(). Having both the singleton and the factory creates API confusion.All 8 call sites (7 source + 1 test) are migrated to use
buildLocationServiceMap()directly. The call sites inserver.tswere already migrated upstream. Pure mechanical replacement, no behavior change.How did you verify your code works?
bun typecheck, 35 packages)grep -r locationServiceMapLayerreturns zero results inpackages/Checklist