fix(app): preload more timeline messages#36172
Open
Hona wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves session timeline loading in the app by increasing the initial message page size so more recent context is available immediately, while keeping the existing larger history pagination behavior. It also updates unit and E2E coverage to validate that initially visible timeline content remains visible while the longer history fetch completes.
Changes:
- Increase the initial session message fetch page size from 2 to 20 (history fetch remains 200).
- Update server-session unit tests to assert the new initial fetch limit.
- Update the timeline history E2E regression to use a larger initial dataset and to validate visibility during the history-load phase.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/app/src/context/server-session.ts | Bumps the initial messages page size used for the first timeline load. |
| packages/app/src/context/server-session.test.ts | Updates expectations to match the new initial fetch limit. |
| packages/app/e2e/regression/session-timeline-history-root.spec.ts | Adjusts the regression scenario/data size and assertions to reflect the new pagination and visibility guarantees. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+131
to
+143
| if (!state.captured && viewport) { | ||
| state.visibleParts = [...viewport.querySelectorAll<HTMLElement>("[data-timeline-part-id]")] | ||
| .map((part) => part.dataset.timelinePartId) | ||
| .filter((partID): partID is string => !!partID && visible(partID)) | ||
| state.captured = true | ||
| } | ||
| if ( | ||
| !virtual || | ||
| state.visibleParts.length === 0 || | ||
| state.visibleParts.some((partID) => !visible(partID)) | ||
| ) | ||
| state.hidden = true | ||
| state.samples++ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing