fix(tui): preserve initial user message on new session hydration#36176
Open
akshitj11 wants to merge 1 commit into
Open
fix(tui): preserve initial user message on new session hydration#36176akshitj11 wants to merge 1 commit into
akshitj11 wants to merge 1 commit into
Conversation
Insert an optimistic user message when submitting the first prompt in a new session so hydration cannot drop it before server events arrive. Reconcile with the server message on message.updated and clear on prompt failure. Fixes anomalyco#35988
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35988
Type of change
What does this PR do?
On a new session's first prompt, the TUI navigates to the session view and runs
session.sync()before the server has persisted the user message. Hydration can complete with only the assistant reply, so the user bubble never appears.This adds an optimistic user message in the sync store at submit time, keeps it through hydration merge, and removes it when the real
message.updatedarrives (or on prompt failure).How did you verify your code works?
cd packages/tui && bun test test/cli/cmd/tui/sync-live-hydration.test.tsxcd packages/tui && bun testcd packages/tui && bun run typecheckAdded regression test:
optimistic user message survives new session hydration race.Screenshots / recordings
No recording yet — race is timing-dependent. Happy to add one with a slow MCP config if needed.
Checklist