HBASE-30025 Wire TieredExclusiveTopology as a CombinedBlockCache-compatible CacheAccessService#8501
Open
VladRodionov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a construction path for creating a topology-backed
CacheAccessServicefrom existing L1 and L2
BlockCacheinstances.The pluggable block cache architecture now has the basic components needed for
topology-backed cache access:
CacheEngineCacheTopologyCachePlacementAdmissionPolicyCacheAccessServiceTieredExclusiveTopologyTopologyBackedCacheAccessServiceBlockCacheBackedCacheEngineThis PR wires those pieces together for the current CombinedBlockCache-style L1/L2
model. Existing
BlockCacheinstances are adapted toCacheEngineusingBlockCacheBackedCacheEngine, assembled into aTieredExclusiveTopology, and exposedthrough
TopologyBackedCacheAccessService.Changes
TopologyBackedCacheAccessServices, a small helper class for constructingtopology-backed cache access services.
fromTieredExclusiveBlockCaches(...)for creating aTopologyBackedCacheAccessServicefrom existing L1 and L2BlockCacheinstances.BlockCacheBackedCacheEnginefor L1 and L2 adaptationTieredExclusiveTopologyCachePlacementAdmissionPolicyWhy this is needed
The current production L1/L2 block cache model is represented by
CombinedBlockCache,typically coordinating
LruBlockCacheas L1 andBucketCacheas L2.The new architecture models this as:
AI assistance disclosure
This PR was prepared with assistance from ChatGPT. All changes were reviewed, tested,
and submitted by the author.