HIVE-29694#6577
Draft
InvisibleProgrammer wants to merge 2 commits into
Draft
Conversation
|
dengzhhu653
reviewed
Jul 6, 2026
| import java.sql.Statement; | ||
| import java.time.Instant; | ||
| import java.time.LocalDateTime; | ||
| import java.time.ZoneId; |
Member
There was a problem hiding this comment.
Nit: keep the order of imports if necessary if we don't want to reformat the code
dengzhhu653
reviewed
Jul 6, 2026
| ACID_TXN_CLEANER_INTERVAL("metastore.acid.txn.cleaner.interval", | ||
| "hive.metastore.acid.txn.cleaner.interval", 10, TimeUnit.SECONDS, | ||
| "Time interval describing how often aborted and committed txns are cleaned."), | ||
| ADD_PARTITION_REUSE_EXISTING_COLUMN_DESCRIPTORS("metastore.add.partition.reuse.existing.column.descriptors", |
Member
There was a problem hiding this comment.
since this is an optimization for large tables, for small tables, it shouldn't introduce too much overhead, should we set the default to true?
dengzhhu653
reviewed
Jul 6, 2026
| import java.util.Collections; | ||
| import java.util.HashMap; | ||
| import java.util.HashSet; | ||
| import java.util.Iterator; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in the corresponding Jira: https://issues.apache.org/jira/browse/HIVE-29694
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?