HIVE-29349: upgrade testcontainers to support docker desktop 29+#6580
Open
InvisibleProgrammer wants to merge 1 commit into
Open
HIVE-29349: upgrade testcontainers to support docker desktop 29+#6580InvisibleProgrammer wants to merge 1 commit into
InvisibleProgrammer wants to merge 1 commit into
Conversation
Contributor
Author
|
@okumin , I faced with the exact same issue as you before. Let's see if a minor upgrade is accepted. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The current version of docker testcontainers doesn't suppport docker versions from 29.
There were a previous attempt to fix the problem by doing a major upgrade: #6220
That attempt failed as it requires upgrades in the CI pipeline as well.
This change is only a minor upgrade change that means it can be done without touching Jenkins at all. And also, with that change, it is possible to run dockerized metastore tests with never docker versions.
What changes were proposed in this pull request?
Upgrade docker testcontainers from 1.21.3 to 1.21.4
Why are the changes needed?
To be able to run metastorecheckin tests with never docker versions.
Here is the current output with docker version 29.4.0:
Does this PR introduce any user-facing change?
No
How was this patch tested?
mvn install -Dtest.groups= -Dtest=TestMysql