fix: Address property macro review follow-ups - #2987
Merged
Conversation
Address the final inline comments from #2970 by documenting generated-code requirements, correcting the illustrative data path default, and covering the optional custom-parser error path.
blackmwk
commented
Aug 12, 2026
blackmwk
commented
Aug 12, 2026
blackmwk
requested review from
CTTY and
laskoviymishka
and removed request for
CTTY
August 12, 2026 03:41
Contributor
Author
|
I think this pr is ready for review, cc @CTTY @laskoviymishka |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
extern crate self as icebergalias is required by generated code.std::Option/std::collections::HashMaprequirement.write.data.path = "warehouse"example default.Option<T>withparse_with.This is the bottom PR in stack #2990; #2988 follows it.
Are these changes tested?
cargo test -p iceberg-property-macrocargo fmt --all -- --checkAI Disclosure
This change was implemented and validated with OpenAI Codex assistance.