Skip to content

[BUILD] IMAPServerIDCommandTest::concurrentIdCommandsInTheSameSession… #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quantranhong1999 merged 1 commit into from
Aug 24, 2026
Merged

[BUILD] IMAPServerIDCommandTest::concurrentIdCommandsInTheSameSession… #3129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions ...tocols-imap4/src/test/java/org/apache/james/imapserver/netty/IMAPServerIDCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.time.Duration;

import org.apache.james.util.concurrency.ConcurrentTestRunner;
import org.apache.james.utils.TestIMAPClient;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;

Expand Down Expand Up @@ -61,15 +62,21 @@ void idCommandShouldReturnConfiguredResponse() throws Exception {
}

@Test
void concurrentIdCommandsInTheSameSessionShouldSucceed() throws Exception {
void concurrentIdCommandsShouldSucceed() throws Exception {
imapServer = createImapServer("imapServer.xml");
int port = imapServer.getListenAddresses().getFirst().getPort();

testIMAPClient.connect("127.0.0.1", imapServer.getListenAddresses().getFirst().getPort());
// One client per thread: a single TestIMAPClient wraps one socket and one
// reader, so sharing it across threads interleaves the replies and a thread
// can read an empty string that belongs to nobody.
ConcurrentTestRunner.builder()
.operation((threadNumber, step) -> {
assertThat(testIMAPClient.sendCommand("ID (\"name\" \"Apache James\")"))
.contains("* ID NIL")
.contains("OK ID completed.");
try (TestIMAPClient client = new TestIMAPClient()) {
client.connect("127.0.0.1", port);
assertThat(client.sendCommand("ID (\"name\" \"Apache James\")"))
.contains("* ID NIL")
.contains("OK ID completed.");
}
})
.threadCount(20)
.operationCount(1)
Expand Down