Build with the logging-parent reusable workflows - #470
Merged
Conversation
Flume no longer maintains its own checkout, JDK and Maven steps, and gains snapshot/release deployment and reproducibility verification in exchange. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
rgoers
self-requested a review
July 28, 2026 21:53
rgoers
approved these changes
Jul 28, 2026
TaildirSource tracks files by inode, so its tests cannot pass when the default file system lacks a `unix` attribute view (e.g. on Windows). Document that requirement in the user guide. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
The last commit disables tests that depend on a UNIX file system: TaildirSource tracks files by inode ( |
The test read from the channel immediately after closing the client socket, but the source delivers events asynchronously, so the take could return null on slow machines (first seen on Windows CI). Wait for the source counter with Awaitility and close the TLS socket gracefully, flushing before close. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
The Windows CI logs show the TLS handshake succeeding and the connection aborting one millisecond later: the client never reads the TLS 1.3 session tickets sent by the server, so close() aborts the connection with a TCP RST, which on Windows discards the syslog record before the server reads it. Assisted-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hand-rolled
build.ymlwithbuild.yaml, delegating to thelogging-parentreusable workflows the waylogging-log4j2does.What changes
buildnow callsbuild-reusable.yaml, replacing the local checkout /setup-java/mvnw verifysteps.deploy-snapshot(ontrunk) anddeploy-release(onrelease/*) jobs.verify-reproducibility-snapshotandverify-reproducibility-releasejobs.Notes for reviewers
build-reusable.yamlhardcodes[macos-latest, ubuntu-latest, windows-latest]and exposes no input to narrow it, whereas the old workflow was Ubuntu-only. The comment blaming protobuf 2.x for the disabled macOS build was stale: Flume is on protobuf 4.35.0, which ships anosx-aarch_64protoc. Windows is untested, and several modules depend on Hadoop, which commonly wantswinutils.exeandHADOOP_HOME.