Skip to content

Follow up of 459 - #1536

Open
rmannibucau wants to merge 8 commits into
masterfrom
pr-459
Open

Follow up of 459#1536
rmannibucau wants to merge 8 commits into
masterfrom
pr-459

Conversation

@rmannibucau

Copy link
Copy Markdown
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

.collect(toSet());
}

private Stream<String> findUsedSpi(final Artifact artifact) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extends a maven-dependency-analyzer with such feature?

Comment thread pom.xml

<prerequisites>
<maven>3.6.3</maven>
<maven>${mavenVersion}</maven>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change

@slachiewicz

This comment was marked as outdated.

@slachiewicz slachiewicz added the waiting-for-feedback Waiting for 90 days until issues or pull request will be closed label Aug 24, 2026
@slachiewicz

Copy link
Copy Markdown
Member

Rebasing this on master stops at a decision rather than a merge conflict, so I left it alone.

Two files conflict, and the one that matters is AbstractAnalyzeMojo.filterDependencies. This branch changes its return from Set<Artifact> to List<Artifact> and drops the empty-excludes short-circuit that master has since added. Choosing a side changes the method's contract and its callers, which is not something to settle on your behalf.

The branch is 8 commits with subjects such as "some draft of a more generic detection of used unused dependencies". If it is still exploratory, cutting a fresh branch from master may be less work than carrying this one forward.

This comment was created with AI assistance.

@github-actions github-actions Bot removed the waiting-for-feedback Waiting for 90 days until issues or pull request will be closed label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants