Support nested values and deletion vectors in batch Diff - #944
Merged
JingsongLi merged 1 commit intoSep 24, 2026
Merged
Conversation
leaves12138
approved these changes
Sep 24, 2026
leaves12138
left a comment
There was a problem hiding this comment.
LGTM. Reviewed ab209d3; no blocking issues found.
Checked recursive ROW/ARRAY/MAP/MULTISET/VECTOR value equality, null-parent handling, NaN/signed-zero semantics, full-value comparison under projection, and independent before/after deletion-vector resolution for both materialized DV and merge-on-read scans.
Local validation (default features):
cargo test --locked -p paimon --lib: 3113 passed, 6 ignored.incremental_batch_scan_test: 39 passed.incremental_diff_extended_test: 6 passed.- Two additional temporary regression tests passed: deeply nested ROW/ARRAY/MAP values with null/empty distinctions and key-only projection; snapshot-specific DVs across small read batches with key filtering and audit-log assertions in both DV modes.
CI has no reported failures at the time of review; some jobs are still running. Optional fulltext/vortex feature builds were not rerun locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ROW,ARRAY,MAP,MULTISET, andVECTORvalues recursively in batch incrementalDiff, including nested nulls, NaNs, and signed zero. Keep primary-key ordering restricted to scalar types.This follows Java
IncrementalDiffSplitRead: compare complete logical values and read each side with its own deletion files.Verification
cargo test --locked -p paimon --test incremental_diff_extended_test --features fulltext,vortex(6 passed)cargo test --locked -p paimon --test incremental_batch_scan_test --features fulltext,vortex(39 passed)cargo test --locked -p paimon --lib table::table_read::tests::test_diff --features fulltext,vortex(4 passed)cargo clippy --locked -p paimon --all-targets --features fulltext,vortex -- -D warningscargo fmt --all -- --check