Support BSI FileIndex and indexed primary-key and data-evolution writes - #947
Merged
Merged
Conversation
leaves12138
approved these changes
Sep 24, 2026
leaves12138
left a comment
There was a problem hiding this comment.
LGTM. Reviewed a88663f; no blocking issues found.
Checked the BSI V1 encoding/value mapping against the Java implementation and the included Java fixture, signed/null and temporal handling, physical index row positions after sorting/merging, partial-file field remapping, and preservation of HASH/input-changelog metadata on the normal commit path. Read-side pruning remains limited to primary-key predicates before sort-merge and independent data-evolution files, preserving residual filtering and column-merge semantics.
Local validation (default features):
cargo test --locked -p paimon --lib: 3136 passed, 6 ignored, including the 10 BSI and 28 file-index writer tests.incremental_batch_scan_testandincremental_diff_extended_test: 39 + 6 passed.- Two additional temporary regression tests passed: BSI selections combined with snapshot-specific DVs, small read batches, projection and Diff/audit reads in both DV modes; data-evolution nonzero row-id offsets, intersected row ranges and updated partial-column values. Both exercised embedded and sidecar indexes with index reads enabled and disabled.
CI has no reported failures at the time of review; three jobs are still running. Optional feature builds were not rerun locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo test -p paimon --lib(3136 passed, 6 ignored)cargo clippy -p paimon --lib -- -D warningscargo fmt --all -- --checkgit diff --check