Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
import org.apache.rocketmq.broker.BrokerController;
import org.apache.rocketmq.broker.pop.orderly.QueueLevelConsumerManager;

import java.util.Objects;
import java.util.concurrent.ConcurrentHashMap;
import java.util.stream.IntStream;

/**
* Memory-based Consumer Order Information Manager for Lite Topics
Expand Down Expand Up @@ -70,6 +72,31 @@ public void suspendQueue(String topic, String group, int queueId, long popTime,
updateLockFreeTimestamp(topic, group, queueId, orderInfo);
}

public boolean isPopTimeMatched(String topic, String group, int queueId, long popTime) {
ConcurrentHashMap<Integer, OrderInfo> queues = getTable().get(buildKey(topic, group));
OrderInfo orderInfo = queues == null ? null : queues.get(queueId);
return orderInfo != null && popTime > 0 && popTime == orderInfo.getPopTime();
}

/**
* Release the unacked lease of an attempt whose response was lost, without committing offset. The negative pop
* time invalidates its receipt handles: a renewal gets NO_MESSAGE, an ack gets success without committing offset.
*/
public boolean releaseQueue(String topic, String group, int queueId, String attemptId) {
ConcurrentHashMap<Integer, OrderInfo> orderInfoMap = this.getTable().get(buildKey(topic, group));
OrderInfo orderInfo = orderInfoMap == null ? null : orderInfoMap.get(queueId);
if (null == orderInfo || null == orderInfo.getOffsetList()
|| !Objects.equals(attemptId, orderInfo.getAttemptId()) || orderInfo.getPopTime() <= 0
|| IntStream.range(0, orderInfo.getOffsetList().size()).noneMatch(orderInfo::isNotAck)) {
return false;
}
orderInfo.setPopTime(-orderInfo.getPopTime());
orderInfo.setInvisibleTime(1L);
orderInfo.setOffsetNextVisibleTime(null);
updateLockFreeTimestamp(topic, group, queueId, orderInfo);
return true;
}

@Override
public void persist() {
// MemoryConsumerOrderInfoManager persist, do nothing.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,11 @@ protected CompletableFuture<RemotingCommand> processChangeInvisibleTimeForLite(
if (requestHeader.getOffset() < oldOffset) {
return CompletableFuture.completedFuture(response);
}
if (!consumerOrderInfoManager.isPopTimeMatched(lmqName, group, 0, popTime)) {
response.setCode(ResponseCode.NO_MESSAGE);
response.setRemark("The lite receipt handle belongs to an expired lease");
return CompletableFuture.completedFuture(response);
}
long visibilityTimeout = System.currentTimeMillis() + requestHeader.getInvisibleTime();
if (requestHeader.isSuspend()) {
consumerOrderInfoManager.suspendQueue(lmqName, group, 0, popTime, visibilityTimeout);
Expand Down

Large diffs are not rendered by default.

Loading
Loading