[SYSTEMDS-3960] Fix federated worker readiness probe on delayed connections - #2587
Open
gaturchenko wants to merge 1 commit into
Open
[SYSTEMDS-3960] Fix federated worker readiness probe on delayed connections#2587gaturchenko wants to merge 1 commit into
gaturchenko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With any delay on the worker's interface, currently every federated test fails before it starts, while the worker is listening the whole time.
FederatedWorkerUtils.tryConnectallocated 25ms per connect attempt, but a TCP handshake needs two traversals of the link which are ~100ms under the delay above. Every attempt expired with aSocketTimeoutException, which is anIOExceptionand therefore indistinguishable from a closed port, so the probe never succeeded.The following changes were implemented:
attemptTimeout), so a slow connect cannot exceed it. The returned value of 0 implies the attempt was never madewaitForWorkersnow rechecks the deadline per port, which can now cost up to 2s each