Skip to content

[FIX][Relax] Restore logical layout before flattening repeat in ConvertLayout #20863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pujitha24 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIX][Relax] Restore logical layout before flattening repeat in ConvertLayout #20863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/relax/op/tensor/manipulate.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1980,9 +1980,11 @@ InferLayoutOutput InferLayoutRepeat(
existing_layout = LayoutDecision(InitialLayout(ndim));
}

// When axis is not specified, the output is 1D (flattened)
// When axis is not specified, the output is the flattened input. Flattening is order-sensitive,
// so the input must be restored to its initial (logical) layout.
if (!attrs->axis.has_value()) {
return InferLayoutOutput({existing_layout}, {InitialLayoutDecision(1)}, call->attrs);
return InferLayoutOutput({InitialLayoutDecision(ndim)}, {InitialLayoutDecision(1)},
call->attrs);
}

// Transform the axis based on the layout
Expand Down
5 changes: 4 additions & 1 deletion tests/python/relax/test_transform_convert_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5076,7 +5076,10 @@ def main(
out_layout="NHWC",
out_dtype="float32",
)
gv2: R.Tensor((5408,), dtype="float32") = R.repeat(gv, repeats=1)
lv2: R.Tensor((2, 4, 26, 26), dtype="float32") = R.permute_dims(
gv, axes=[0, 3, 1, 2]
)
gv2: R.Tensor((5408,), dtype="float32") = R.repeat(lv2, repeats=1)
R.output(gv2)
return gv2

Expand Down