Repository navigation
Conversation
agnosticdev
approved these changes
Oct 13, 2026
| } | ||
| if removedEntry.lostTime != .zero, lostPacketCount > 0 { | ||
| lostPacketCount &-= 1 | ||
| } |
Collaborator
There was a problem hiding this comment.
So this missing branch looks like it was throwing our book-keeping off?
if removedEntry.lostTime != .zero, lostPacketCount > 0 {
lostPacketCount &-= 1
}
Contributor
Author
There was a problem hiding this comment.
The main problem is that we were not keeping packets in the list when they were declared lost, so there was no way to detect spurious losses.
- Report spurious retransmits and loss-related congestion events to the path a packet was sent on, not the path its ACK arrived on - Retain lost packets for up to one RTT so a late ACK is recognized as a spurious loss and undoes the congestion window reduction - Pass the correct largest-lost sent time so a new congestion event isn't hidden on fresh connections - Rename `path`/`pathID` to `sentPath`/`sentPathID` for clarity and add tests covering single- and multi-path spurious loss recovery
rpaulo
force-pushed
the
recovery-spurious
branch
from
October 13, 2026 20:21
08efc6d to
377adf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path/pathIDtosentPath/sentPathIDfor clarity and add tests covering single- and multi-path spurious loss recovery