Repository navigation
Detect incomplete IPUDPTransfer datagrams - #251
Merged
Merged
Conversation
danielsyauqi
requested review from
agnosticdev,
ekinnear and
tfpauly
as code owners
October 13, 2026 11:51
agnosticdev
reviewed
Oct 13, 2026
agnosticdev
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the change. Just one comment regarding the test.
rpaulo
approved these changes
Oct 14, 2026
agnosticdev
approved these changes
Oct 14, 2026
tfpauly
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
IPUDPTransferpreviously treated any non-nil read as a completed transfer. With a 1,473-byte payload, the receiver gets an empty datagram, but the benchmark reported success. Checking length catches empty and truncated receives without adding a byte-by-byte comparison to the timed packet loop.Testing
swift test -c releaseswift test --filter IPUDPTransferTests -Xswiftc -warnings-as-errorsswift format lint --strict Package.swift Sources/Tools/IPUDPTransfer/main.swift Tests/IPUDPTransferTests/IPUDPTransferTests.swiftCloses #250