fix(db): check the task error before the ARN print - #179
Open
ipmb wants to merge 1 commit into
Open
Conversation
`apppack db load` starts an ECS task with `StartTask`. If the call fails, it returns a nil task and an error. The command printed `*task.TaskArn` before the error check, so the CLI panicked and hid the real cause. Move `checkErr(err)` to the line after the `StartTask` call. This matches the order in `cmd/shell.go`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
apppack db loadstarts an ECS task withStartTask. If the call fails,StartTaskreturns a nil task and an error. The command printed*task.TaskArnbefore it checked the error. The CLI then panicked, and the user did not see the real cause.Change
Move
checkErr(err)to the line after theStartTaskcall. The CLI now prints the error and stops. This matches the order incmd/shell.go.Tests
go build ./...— OKgo test ./cmd/— OK🤖 Generated with Claude Code