Repository navigation
Conversation
🔵 Tier A · Mergeable after minor fixes
Updates the pinned PHP base image digest and upgrades MongoDB from 2.5.2 to 2.5.3 and Swoole from 6.2.2 to 6.2.3. Both extension versions retain immutable commit pins.
Fix with agent prompt### Issue 1
Dockerfile:30-31
**Update the structure-test expectation for Swoole 6.2.3**
`tests.yaml:127` still requires `version 6.2.2`, so the newly built 6.2.3 image will fail the Container Structure Test workflow, which runs that configuration on every push. Please update the expectation alongside the version bump.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 1
Reviewed |
Comment on lines
+30
to
+31
| PHP_SWOOLE_VERSION="v6.2.3" \ | ||
| PHP_SWOOLE_COMMIT="8b20cd39f8c19da7aaf70290037e04f616db5ff7" \ |
There was a problem hiding this comment.
Update the structure-test expectation for Swoole 6.2.3
tests.yaml:127 still requires version 6.2.2, so the newly built 6.2.3 image will fail the Container Structure Test workflow, which runs that configuration on every push. Please update the expectation alongside the version bump.
Prompt To Fix With AI
This is a comment left during a code review.
Path: Dockerfile
Line: 30-31
Comment:
**Update the structure-test expectation for Swoole 6.2.3**
`tests.yaml:127` still requires `version 6.2.2`, so the newly built 6.2.3 image will fail the Container Structure Test workflow, which runs that configuration on every push. Please update the expectation alongside the version bump.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated weekly dependency update.
Dependency update report
sha256:4992c6fda82eadfb3b22dca3929188dc5831e9f44a3d42b3c8d36a460b4d5a80sha256:93684051146ec037620855feb77f278090bde45ddc030801cd3f2a7685bc4deb0.21.00.21.0ced23f5b6f523.8.13.8.170087bab33ea0.7.10.7.1065a57d8fe23v1.14.0v1.14.0f3c92f68b3be2.5.22.5.33551aa91ec765.36.25.36.2f0a17c67de296.3.06.3.0df4fab2de7fc2.0.22.0.25a14bc7664230.2.30.2.3d31b77d63955v6.2.2v6.2.38b20cd39f8c13.5.33.5.3127bbcb980402.3.02.3.0c1f0d8ba5ef30.18.00.18.0c2593a4ce245Updates: 3
Dockerfile pins were updated.