Repository navigation
pjsip: Make presencestate_repeat_okay predictable. - #157
Merged
github-actions[bot] merged 1 commit intoOct 1, 2026
Merged
Conversation
Member
Author
|
cherry-pick-to: 24 |
The PJSIP presencestate_repeat_okay test set the presence status one after another. Depending on the system this could result in a NOTIFY being skipped as a presence state update inside of Asterisk is merely a notification that it changed and the presence state has to be queried. If the presence state was updated to the second value it was then possible for the first value to be skipped. This change removes the Python module as the test can be expressed solely through yaml and also makes the presence state updates sequential based on the update of the prior one being confirmed done via an AMI event.
jcolp
force-pushed
the
presencestate-repeat-okay
branch
from
September 30, 2026 13:49
21909b0 to
655fad8
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
Workflow Check completed successfully |
github-actions
Bot
added
cherry-pick-testing-in-progress
|
Workflow CPCheck completed successfully |
gtjoseph
added
merge-approved
and removed
cherry-pick-checks-failed
github-actions
Bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["20","22","23","24"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PJSIP presencestate_repeat_okay test set the presence status one after another. Depending on the system this could result in a NOTIFY being skipped as a presence state update inside of Asterisk is merely a notification that it changed and the presence state has to be queried. If the presence state was updated to the second value it was then possible for the first value to be skipped.
This change removes the Python module as the test can be expressed solely through yaml and also makes the presence state updates sequential based on the update of the prior one being confirmed done via an AMI event.