Skip to content

feat(project): implement safe CDK deployment - #2058

Open
notgitika wants to merge 3 commits into
feat/project-cdk-toolkitfrom
feat/project-deploy-implementation
Open

feat(project): implement safe CDK deployment#2058
notgitika wants to merge 3 commits into
feat/project-cdk-toolkitfrom
feat/project-deploy-implementation

Conversation

@notgitika

@notgitika notgitika commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • resolve and validate one deployment target before backend dispatch
  • resolve one CDK CLI-compatible credential provider and share it across STS, CloudFormation, and Toolkit operations
  • reject credentials for the wrong AWS account before synthesis or mutation
  • synthesize to a fixed assembly directory and select exactly one tagged stack
  • bootstrap only absent or stably outdated environments, propagating unsafe and ambiguous states
  • deploy through the backend-local Toolkit adapter and return stack outputs
  • embed and clean up the Toolkit bootstrap template for standalone executables

Stack

This is PR 4 of 4 decomposing #2001 and is the first PR in the stack that activates deployment. Review and merge bottom-up.

  1. refactor(project): move build behind a project backend #2055 - backend build boundary
  2. feat(project): add deploy command contract #2056 - deploy command contract
  3. feat(project): add CDK Toolkit adapter #2057 - CDK Toolkit adapter
  4. feat(project): implement safe CDK deployment #2058 - safe deployment implementation (this PR)

Follow-ups

  • Revisit and document the inherited createCustomerMasterKey: true bootstrap policy, including recurring KMS cost and security rationale. This PR preserves the shipped CLI behavior.
  • Define confirmation and ownership semantics before changing shared CDKToolkit stacks, including externally managed bootstrap infrastructure tracked by Hard-coded CDKToolkit stack name causes false bootstrap prompt #1799.

typecheck, lint, format, test all pass
did npm bundle and standalone executable smoke tests

@github-actions github-actions Bot added the size/xl PR size: XL label Aug 20, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress size/xl PR size: XL and removed size/xl PR size: XL agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 20, 2026
@notgitika
notgitika force-pushed the feat/project-deploy-implementation branch from e34662d to c843d80 Compare August 20, 2026 04:19
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika marked this pull request as ready for review August 20, 2026 04:24
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Aug 20, 2026
@notgitika
notgitika force-pushed the feat/project-deploy-implementation branch from c76b638 to 8ea3f87 Compare August 20, 2026 17:06
@github-actions github-actions Bot removed the size/xl PR size: XL label Aug 20, 2026
@github-actions github-actions Bot added the size/xl PR size: XL label Aug 20, 2026
@notgitika
notgitika force-pushed the feat/project-deploy-implementation branch from 8ea3f87 to 6a50f83 Compare August 21, 2026 16:10
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.45643% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.08%. Comparing base (d5e69ff) to head (9d9e7f6).

Files with missing lines Patch % Lines
src/core/project/backends/cdk/environment.ts 72.97% 20 Missing ⚠️
src/core/project/backends/cdk/toolkit.ts 93.02% 3 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/project-cdk-toolkit    #2058      +/-   ##
============================================================
- Coverage                     97.15%   97.08%   -0.08%     
============================================================
  Files                           388      390       +2     
  Lines                         23202    23427     +225     
============================================================
+ Hits                          22543    22745     +202     
- Misses                          659      682      +23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notgitika
notgitika force-pushed the feat/project-deploy-implementation branch from 6a50f83 to 8fc3679 Compare August 21, 2026 16:16
@notgitika
notgitika force-pushed the feat/project-deploy-implementation branch from 8fc3679 to f3c270c Compare August 21, 2026 17:43
@notgitika
notgitika force-pushed the feat/project-deploy-implementation branch from f3c270c to 9168096 Compare August 21, 2026 18:13
@notgitika
notgitika force-pushed the feat/project-deploy-implementation branch from 9168096 to 9d9e7f6 Compare August 21, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants