fix(online-eval): correct --agent help to runtime-only - #2065
Merged
Conversation
Only runtimes are valid online-eval targets end-to-end: the project superRefine builds agentNames from spec.runtimes, and the CDK construct resolves config.agent against the runtime-only environments map, so a harness name always fails. Correct the help text to match. Related: aws/agentcore-l3-cdk-constructs#335
github-actions
Bot
added
agentcore-harness-reviewing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2065 +/- ##
=========================================
Coverage 97.11% 97.11%
=========================================
Files 384 384
Lines 22725 22725
=========================================
Hits 22069 22069
Misses 656 656 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nborges-aws
approved these changes
Aug 21, 2026
notgitika
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
online-insightPR (#2063), applying the same one-line fix toonline-eval.Change
add online-eval--agenthelp text:"harness/runtime name …"→"runtime name …".Why
Only runtimes are valid online-eval targets end-to-end, so the old wording promised harness support that no layer implements:
ProjectSpecSchemasuperRefine buildsagentNamesfromspec.runtimesonly — a harness name always raises "references unknown agent".config.agentagainst a runtime-onlyenvironmentsmap and derives the monitored log group from a runtime id.Adding harnesses to the validation set would be worse (it'd pass CLI validation, then fail at CDK synth). Real harness support is a construct-level feature tracked separately.
Related: aws/agentcore-l3-cdk-constructs#335
Verification
tsc --noEmit0 errors ·prettier --checkclean ·online-evalsuite 16/16 (help-text change is test-neutral — no test asserts the string).