Repository navigation
perf(serde): Compile per-shape JSON and XML serde plans with caching #3363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohangavankar
wants to merge
37
commits into
aws:master
Choose a base branch
from
rohangavankar:serde-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
49970a8
Serde plan foundation: shared per-shape plan cache
rohangavankar db69452
chore(serde): Add JSON serde spec and before/after benchmark
rohangavankar d8d4d80
perf(serde): Compile JSON encode plans per shape
rohangavankar 39a0737
perf(serde): Compile JSON decode plans per shape
rohangavankar e6b46f9
perf(serde): Add x86 merge-grade JSON encode benchmarks
rohangavankar 3ec175c
perf(serde): Add x86 merge-grade JSON decode benchmarks
rohangavankar 6d105fe
docs(serde): Mark JSON encode and decode steps complete with x86 results
rohangavankar ea2a691
docs(serde): Add JSON serde phase summary with x86 results
rohangavankar e3b48c3
Merge branch 'aws:master' into serde-cache
rohangavankar fe46ffe
perf(serde): Add memory, large-payload, and full-corpus x86 benchmarks
rohangavankar ef39d55
Merge remote-tracking branch 'origin/serde-cache' into serde-cache
rohangavankar 456264b
chore(serde): Keep benchmark results out of the public SDK
rohangavankar c0ccc80
test(serde): Add JSON plan compilation and invalidation unit tests
rohangavankar c041f9a
test(serde): Cover root timestamp decode plan compilation
rohangavankar 3f83880
test(serde): Cover offsetUnset and list/map resolved-child clearing
rohangavankar 57d363d
perf(serde): Compile XML encode plans per shape
rohangavankar 729a74c
perf(serde): Compile XML decode plans per shape
rohangavankar e5ab968
refactor(serde): Rename plan cache accessors to match architecture.md
rohangavankar c285853
docs(serde): Restore explanatory comments in XmlParser legacy path
rohangavankar a727224
perf(serde): Compile XML root element name into the encode plan
rohangavankar 919e342
chore(serde): Exclude benchmark/ from the published package
rohangavankar 2b0d224
Merge remote-tracking branch 'upstream/master' into serde-cache
rohangavankar 1f4413d
chore: Remove .kiro spec dir from PR (local tooling artifact)
rohangavankar cac0a80
chore: Remove benchmark harness from PR (keep off public repo)
rohangavankar 3ec3919
style(serde): Apply PHPCS autofixes to touched files
rohangavankar 4f484b8
style(serde): Suppress camel-case sniff on legacy dispatch methods
rohangavankar 83b652c
fix(serde): Keep null list elements null in JSON decode
rohangavankar bdd80cf
fix(serde): Write only string xmlAttribute members as attributes
rohangavankar 6f4956d
fix(serde): Refresh operation context params on model change
rohangavankar f9aa409
style(serde): Keep first condition on the if line
rohangavankar ce903a9
refactor(serde): Remove legacy parse and build paths
rohangavankar e12b87e
fix(serde): Resolve XML root name only for the root shape
rohangavankar 4791638
chore: Drop leftover benchmark ignore entries
rohangavankar fbf61a6
fix(serde): Rebuild operation context params after shape mutation
rohangavankar 701c316
style(serde): Fix PHPCS findings in serde parsers and plans
rohangavankar c1eee3e
fix(serde): Read live contextParam and guard XML attribute key
rohangavankar e895ae7
chore: Add changelog entry for serde plan cache
rohangavankar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| [ | ||
| { | ||
| "type": "enhancement", | ||
| "category": "Api", | ||
| "description": "Caches compiled JSON and XML serialization and parsing plans on model shapes, reducing per-request serialization and parsing overhead. Wire output and parsed results are unchanged, and plans are invalidated when a shape is mutated." | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new generation check rebuilds context parameters, but
getContextParam()still returns the value copied during construction. Directly mutating or removing a member’scontextParamincrements the generation but returns the old context parameter. Read from the mutable definition or refresh the cached property, and test direct mutation/removal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in c1eee3e.
getContextParam()now reads the live definition, so mutating or removing a member'scontextParamis reflected ingetContextParam()andgetContextParams(). The protected$contextParamproperty is still set in the constructor for subclasses. Test:testContextParamsFollowMemberContextParamMutationcovers mutation and removal.