Skip to content

Clamp sidebar resize to a minimum width - #2239

Open
danielvanza wants to merge 2 commits into
aws:mainfrom
danielvanza:sidebar-width-clamp
Open

danielvanza wants to merge 2 commits into
aws:mainfrom
danielvanza:sidebar-width-clamp

Conversation

@danielvanza

@danielvanza danielvanza commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Clamp sidebar resize updates to a shared 200 px minimum in both Graph and Schema views, preventing zero or negative persisted widths.
  • Add a clamp regression in each view's hook suite.
  • Sync with current main (b864b5d2), resolving the layout-defaults conflict while preserving the newer session-scoped layout codecs.

Validation

  • pnpm checks passed: lint, format, and all workspace type checks.
  • LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 pnpm test passed: 251 files, 3,345 tests, including both sidebar-clamp regressions. The explicit locale makes the host match the test suite's expected en-US number formatting.

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have verified pnpm checks passes with no errors.
  • I have verified pnpm test passes with no failures using the locale noted above.
  • I have covered new added functionality with unit tests if necessary.
  • I have updated documentation if necessary.

@danielvanza
danielvanza marked this pull request as ready for review September 22, 2026 21:18
@danielvanza

Copy link
Copy Markdown
Contributor Author

Updated in 1b8fd49: merged current main and resolved the layout-defaults conflict, preserving both the sidebar minimum-width clamp and the newer session-scoped layout codec. pnpm checks passes. LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 pnpm test passes all 3,345 tests; the locale flags avoid the host-specific number-formatting failures. The update is pushed and ready for review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar resize can persist a zero or negative width

1 participant