Repository navigation
Conversation
struct io_uring_buf_reg has gotten the "min_size" field added recently, and now something for alignment for incremental consumption is being worked on. io_uring_setup_buf_ring has the original fields as function parameters, individually, so there's no way to pass min_size or anything else added in the future. Rather than creating a new variant with different parameters each time something gets added, this just creates one that takes io_uring_buf_reg as input. This way, at least additions that don't need special handling in setup can just be transparently passed through to the kernel. It's const since (a) it can indeed be a constant for simple applications and (b) it makes obvious to consumers it won't be updated for changes. Test by running recvmsg-inc-tail twice, the 2nd time using this new function instead of setting up its own buffer ring. Signed-off-by: David 'equinox' Lamparter <equinox@diac24.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context: #1657 (comment) (nothing related to alignment yet, just prep work. It's useful on its own since it allows using
min_leftwith liburing buffer ring setup.)I'm a little unhappy with the long function name but didn't have better/shorter ideas.
Also, there's that architecture specific part for HPPA… I compile-tested with a cross compiler but can't properly test it. At least I don't seem to have made silly typos making it outright fail build.
struct io_uring_buf_reg has gotten the "min_size" field added recently, and now something for alignment for incremental consumption is being worked on. io_uring_setup_buf_ring has the original fields as function parameters, individually, so there's no way to pass min_size or anything else added in the future.
Rather than creating a new variant with different parameters each time something gets added, this just creates one that takes io_uring_buf_reg as input. This way, at least additions that don't need special handling in setup can just be transparently passed through to the kernel. It's const since (a) it can indeed be a constant for simple applications and (b) it makes obvious to consumers it won't be updated for changes.
Test by running recvmsg-inc-tail twice, the 2nd time using this new function instead of setting up its own buffer ring.
git request-pull output:
By submitting this pull request, I acknowledge that: