Conversation
Bump the toolchain across mise, go.mod, the smoke module, and the nix derivation (nixpkgs still carries 1.27rc3, so the existing conditional source-tarball override takes over until it catches up). golangci-lint moves v2.11.1 -> v2.13.1 in lockstep everywhere it is pinned: the old binary was built with Go 1.26 and refuses a 1.27 target, and v2.13.1's release binaries are built with Go 1.27.0.
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
The bats fixtures pinned v2.11.1, which the raised v2.13.1 floor now rejects.
jeremy
approved these changes
Aug 24, 2026
jeremy
left a comment
jeremy
left a comment
Member
There was a problem hiding this comment.
CodeQL support for Go 1.27 coming in a release later this week.
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the toolchain to Go 1.27.0 across everything that pins it:
.mise.toml,go.mod, andtests/smoke/go.modmove to 1.27.0. CI workflows readgo-version-file: go.mod, so they follow on their own.nix/go.nixmoves its base togo_1_27withminGo = "1.27.0"and the official source-tarball hash. The pinned nixpkgs only carries 1.27rc3, so the file's existing conditional override rebuilds from the upstream tarball and drops itself once nixpkgs catches up — the same pattern it used for 1.26.6.tools, both workflows, pre-commit, and theMIN_VERSIONfloor inscripts/check-lint-lockstep.sh). The old binary was built with Go 1.26 and refuses a 1.27 target; v2.13.1's release binaries are built with Go 1.27.0.make checkpasses in full locally: fmt, vet, lint (0 issues), all tests, tidy-check, surface snapshot, and both lockstep checks. The nix path is unverified locally (no nix on this machine) — the nix-build job is the check for that.Dependency
PR #304 is the cached-Go 1.26.6 foundation and should merge first. After it lands, sync this branch with current main before advancing #296. The PR base remains main for now; no history is rewritten while the foundation is under review.