Repository navigation
Report activate and deactivate no-ops in text output - #74
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The no-op behavior is implemented consistently across deployment/environment handlers and is covered by both unit tests and an e2e assertion for the new output.
Pull request overview
Updates the CLI’s human-readable (text) output to explicitly report when model deployment/environment activate/deactivate operations are no-ops (already active/inactive), while keeping the JSON output behavior as a direct passthrough of the API response. This also documents idempotency in command help text and adds both unit and e2e coverage for the new no-op paths.
Changes:
- Add
no_op-aware text-mode messages for model deployment/environment activate/deactivate handlers. - Extend command help text to document idempotent (de)activation behavior and the corresponding text output.
- Add unit tests for no-op responses and an e2e “Activate” phase asserting the
success/no_opJSON shape and the text no-op line.
File summaries
| File | Description |
|---|---|
| internal/e2e-tests/model_test.go | Adds an e2e phase validating idempotent activation behavior (JSON no_op and text message). |
| internal/cmd/command.model_environment.go | Updates environment activate/deactivate text output to report no-op cases. |
| internal/cmd/command.model_environment_test.go | Adds unit tests for environment activate/deactivate no-op responses. |
| internal/cmd/command.model_deployment.go | Updates deployment activate/deactivate text output to report no-op cases. |
| internal/cmd/command.model_deployment_test.go | Adds unit tests for deployment activate/deactivate no-op responses. |
| cmd/command.model_environment.go | Updates help text to document idempotency and no-op text output for environment (de)activation. |
| cmd/command.model_deployment.go | Updates help text to document idempotency and no-op text output for deployment (de)activation. |
| go.mod | Bumps github.com/basetenlabs/baseten-go dependency to a newer pseudo-version. |
| go.sum | Updates checksums for the bumped baseten-go pseudo-version. |
Review details
- Files reviewed: 8/9 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hbd
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What
Pending basetenlabs/baseten-go#37 and need to update go.mod after that merges
💻 How
no_opresponse field in the four activate/deactivate handlers; JSON output unchanged🔬 Testing
Activatephase asserting an activate against the already-active deployment returnssuccess: true, no_op: trueand prints the no-op line