junos_bgp_socket_buffers: un-sickbay now that receive-buffer and send-buffer are parsed - #243
Merged
Merged
Conversation
…-buffer are parsed batfish/batfish#10376 parses both statements, so Batfish defines dut's neighbors and test_main_rib_routes[dut] and test_bgp_rib_routes[dut] pass. Remove the sickbay and refresh the README's Batfish notes. ---- Prompt: ``` 10376 is open to fix the issues. Wait for it to merge, then fix the lab ```
dhalperi
enabled auto-merge (squash)
October 2, 2026 00:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 83.59% 83.59%
=======================================
Files 96 96
Lines 4706 4706
=======================================
Hits 3934 3934
Misses 772 772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batfish/batfish#10376 parses both statements, so Batfish defines dut's
neighbors and test_main_rib_routes[dut] and test_bgp_rib_routes[dut]
pass. Remove the sickbay and refresh the README's Batfish notes.
Prompt: