junos: add lab for OSPF process-level topology default metric - #244
Merged
Merged
Conversation
Single vJunos-router 25.4R1.12 node with a cEOS OSPF/OSPF3 peer, testing the undocumented `set protocols ospf topology default metric 65450`. Junos rejects it with a syntax error at `metric` for OSPF and at `topology` for OSPF3, in the master instance and in a virtual-router, whether entered with `set`, `load set terminal`, or `load merge terminal`. The load commands keep the valid prefix, so a bulk load commits a bare `topology default;`, which has no operational effect. The documented interface-level `topology default metric` (OSPF) and `metric` (OSPF3) are the positive control; the collected snapshot has both, plus the bare process-level stanza, which Batfish reports as unrecognized syntax. ---- Prompt: ``` Using a real Junos device, validate whether Junos accepts this undocumented process-level command: set protocols ospf topology default metric 65450 Test OSPF and OSPF3 at the process level, including within a routing instance if practical. Use the documented interface- level topology metric syntax as a positive control. Determine whether the process-level command commits, appears in normalized configuration output, and has any observable operational effect. Record the platform, exact Junos version, commands, commit-check output, normalized configuration, and relevant operational output. Use an isolated configuration and restore the device afterward. Add the anonymized results to batfish/lab-validation and open a PR. Do not modify Batfish. ```
dhalperi
enabled auto-merge (squash)
October 2, 2026 00:56
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 83.59% 83.59%
=======================================
Files 96 96
Lines 4706 4706
=======================================
Hits 3934 3934
Misses 772 772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dhalperi
added a commit
to batfish/batfish
that referenced
this pull request
Oct 2, 2026
Accept empty OSPF topology containers and represent overload as a topology subcommand. Process-level topology metrics remain unrecognized. For batfish/lab-validation#244. ---- Prompt: ``` Use the OSPF lab results in batfish/lab-validation#244 to correct Junos OSPF topology parsing and tests. ```
dhalperi
added a commit
to batfish/batfish
that referenced
this pull request
Oct 2, 2026
Accept empty OSPF topology containers and represent overload as a topology subcommand. Process-level topology metrics remain unrecognized. For batfish/lab-validation#244. ---- Prompt: ``` Use the OSPF lab results in batfish/lab-validation#244 to correct Junos OSPF topology parsing and tests. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single vJunos-router 25.4R1.12 node with a cEOS OSPF/OSPF3 peer, testing
the undocumented
set protocols ospf topology default metric 65450.Junos rejects it with a syntax error at
metricfor OSPF and attopologyfor OSPF3, in the master instance and in a virtual-router,whether entered with
set,load set terminal, orload merge terminal. The load commands keep the valid prefix, so a bulk loadcommits a bare
topology default;, which has no operational effect.The documented interface-level
topology default metric(OSPF) andmetric(OSPF3) are the positive control; the collected snapshot hasboth, plus the bare process-level stanza, which Batfish reports as
unrecognized syntax.
Prompt: