Skip to content

junos: add lab for OSPF process-level topology default metric - #244

Merged
dhalperi merged 1 commit into
mainfrom
junos-ospf-topology-metric
Oct 2, 2026
Merged

dhalperi merged 1 commit into
mainfrom
junos-ospf-topology-metric

Conversation

@dhalperi

@dhalperi dhalperi commented Oct 2, 2026

Copy link
Copy Markdown
Member

Single vJunos-router 25.4R1.12 node with a cEOS OSPF/OSPF3 peer, testing
the undocumented set protocols ospf topology default metric 65450.
Junos rejects it with a syntax error at metric for OSPF and at
topology for OSPF3, in the master instance and in a virtual-router,
whether entered with set, load set terminal, or load merge terminal. The load commands keep the valid prefix, so a bulk load
commits a bare topology default;, which has no operational effect.
The documented interface-level topology default metric (OSPF) and
metric (OSPF3) are the positive control; the collected snapshot has
both, plus the bare process-level stanza, which Batfish reports as
unrecognized syntax.


Prompt:

Using a real Junos device, validate whether Junos accepts this undocumented process-level command:

  set protocols ospf topology default metric 65450

  Test OSPF and OSPF3 at the process level, including within a routing instance if practical. Use the documented interface-
  level topology metric syntax as a positive control. Determine whether the process-level command commits, appears in
  normalized configuration output, and has any observable operational effect.

  Record the platform, exact Junos version, commands, commit-check output, normalized configuration, and relevant operational
  output. Use an isolated configuration and restore the device afterward.

  Add the anonymized results to batfish/lab-validation and open a PR. Do not modify Batfish.

Single vJunos-router 25.4R1.12 node with a cEOS OSPF/OSPF3 peer, testing
the undocumented `set protocols ospf topology default metric 65450`.
Junos rejects it with a syntax error at `metric` for OSPF and at
`topology` for OSPF3, in the master instance and in a virtual-router,
whether entered with `set`, `load set terminal`, or `load merge
terminal`. The load commands keep the valid prefix, so a bulk load
commits a bare `topology default;`, which has no operational effect.
The documented interface-level `topology default metric` (OSPF) and
`metric` (OSPF3) are the positive control; the collected snapshot has
both, plus the bare process-level stanza, which Batfish reports as
unrecognized syntax.

----

Prompt:
```
Using a real Junos device, validate whether Junos accepts this undocumented process-level command:

  set protocols ospf topology default metric 65450

  Test OSPF and OSPF3 at the process level, including within a routing instance if practical. Use the documented interface-
  level topology metric syntax as a positive control. Determine whether the process-level command commits, appears in
  normalized configuration output, and has any observable operational effect.

  Record the platform, exact Junos version, commands, commit-check output, normalized configuration, and relevant operational
  output. Use an isolated configuration and restore the device afterward.

  Add the anonymized results to batfish/lab-validation and open a PR. Do not modify Batfish.
```
@dhalperi
dhalperi enabled auto-merge (squash) October 2, 2026 00:56
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.59%. Comparing base (2a77265) to head (7221ee6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          96       96           
  Lines        4706     4706           
=======================================
  Hits         3934     3934           
  Misses        772      772           
Flag Coverage Δ
unittests 83.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhalperi
dhalperi merged commit 2752731 into main Oct 2, 2026
149 checks passed
@dhalperi
dhalperi deleted the junos-ospf-topology-metric branch October 2, 2026 01:12
dhalperi added a commit to batfish/batfish that referenced this pull request Oct 2, 2026
Accept empty OSPF topology containers and represent overload as a
topology subcommand. Process-level topology metrics remain
unrecognized.

For batfish/lab-validation#244.

----

Prompt:
```
Use the OSPF lab results in batfish/lab-validation#244 to correct Junos OSPF topology parsing and tests.
```
dhalperi added a commit to batfish/batfish that referenced this pull request Oct 2, 2026
Accept empty OSPF topology containers and represent overload as a
topology subcommand. Process-level topology metrics remain
unrecognized.

For batfish/lab-validation#244.

----

Prompt:
```
Use the OSPF lab results in batfish/lab-validation#244 to correct Junos OSPF topology parsing and tests.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants