Repository navigation
Make bazel-toolchains work for Java 21.0.12.1 - #1103
Merged
Merged
Conversation
Java doesn't use semver, so it's incorrect to attempt to parse the version using the semver library. Semver is currently throwing an error when trying to construct a toolchain for Java 21.0.12.1.
ted-xie
requested review from
DaveGay,
rbe-toolchains-pr-bot and
smukherj1
as code owners
September 29, 2026 16:51
Contributor
Author
|
FYI @coeuvre |
coeuvre
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openjdk doesn't use semver, so it's incorrect to attempt to parse the version using the semver library. Semver is currently throwing an error when trying to construct a toolchain for Java 21.0.12.1.
Should fix the presubmit errors for bazelbuild/continuous-integration#2891 seen here: https://buildkite.com/bazel-testing/ci-smoke-test/builds/239