Skip to content

tighten up zizmor - #172

Merged
bckohan merged 1 commit into
mainfrom
zizmor
Sep 2, 2026
Merged

bckohan merged 1 commit into
mainfrom
zizmor

Conversation

@bckohan

@bckohan bckohan commented Sep 2, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings September 2, 2026 20:28
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (57bfbcc) to head (0e6bfc1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          414       414           
  Branches        85        85           
=========================================
  Hits           414       414           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Multiple workflows will likely fail due to invalid reusable-workflow uses paths and missing actions token permissions required for artifact upload/download.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR aims to tighten CI security posture and reduce wasted CI capacity by adding Zizmor workflow scanning, introducing concurrency controls, and narrowing GitHub Actions token permissions.

Changes:

  • Add a Zizmor workflow plus a just zizmor task, and ignore generated SARIF output.
  • Add concurrency groups to several workflows to cancel superseded runs.
  • Restrict and clarify workflow/job permissions; pin just version in CI via setup-just.
File summaries
File Description
justfile Adds a zizmor task and includes it in check-all.
.gitignore Ignores generated zizmor.sarif.
.github/zizmor.yml Adds Zizmor configuration (disables one rule).
.github/workflows/zizmor.yml Adds concurrency and runs Zizmor with the auditor persona.
.github/workflows/test.yml Adds concurrency and pins just version; removes per-job permissions.
.github/workflows/scorecard.yml Adds concurrency and replaces read-all with explicit permissions.
.github/workflows/release.yml Tightens permissions, adjusts checkout credentials behavior, and pins just version.
.github/workflows/lint.yml Adds concurrency and pins just version.
Review details

Suppressed comments (3)

.github/workflows/release.yml:28

  • uses: $/.github/workflows/test.yml is not a valid path for a local reusable workflow, so this job will fail to load. The called test workflow uploads artifacts, so the caller also needs to grant actions: write.
  test:
    permissions:
      contents: read
      id-token: write # to allow codecov oidc upload
    uses: $/.github/workflows/test.yml

.github/workflows/release.yml:34

  • build uploads artifacts via actions/upload-artifact, but its token permissions only include contents: read. With explicit permissions set, artifact upload requires granting actions: write for this job.
  build:
    name: Build Package
    runs-on: ubuntu-latest
    permissions:
      contents: read

.github/workflows/test.yml:195

  • coverage-combine downloads artifacts via actions/download-artifact, but its job-level permissions omit the actions scope (unspecified scopes become none). Grant at least actions: read so artifact download works.
    permissions:
      contents: read
      id-token: write # for oidc authentication to codecov
  • Files reviewed: 7/8 changed files
  • Comments generated: 4
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 19 to +22
lint:
permissions:
contents: read
actions: write
uses: ./.github/workflows/lint.yml
uses: $/.github/workflows/lint.yml
Comment on lines 27 to +29
permissions:
security-events: write
id-token: write
security-events: write # allow uploading code scanning results
id-token: write # to allow OIDC authentication for publishing results to OpenSSF REST API
Comment on lines 3 to +5
permissions:
contents: read


Comment on lines 23 to +25
permissions:
contents: read
security-events: write
security-events: write # for post to GH security
@bckohan
bckohan merged commit a439dfd into main Sep 2, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants