Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 414 414
Branches 85 85
=========================================
Hits 414 414 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Multiple workflows will likely fail due to invalid reusable-workflow uses paths and missing actions token permissions required for artifact upload/download.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to tighten CI security posture and reduce wasted CI capacity by adding Zizmor workflow scanning, introducing concurrency controls, and narrowing GitHub Actions token permissions.
Changes:
- Add a Zizmor workflow plus a
just zizmortask, and ignore generated SARIF output. - Add
concurrencygroups to several workflows to cancel superseded runs. - Restrict and clarify workflow/job permissions; pin
justversion in CI viasetup-just.
File summaries
| File | Description |
|---|---|
justfile |
Adds a zizmor task and includes it in check-all. |
.gitignore |
Ignores generated zizmor.sarif. |
.github/zizmor.yml |
Adds Zizmor configuration (disables one rule). |
.github/workflows/zizmor.yml |
Adds concurrency and runs Zizmor with the auditor persona. |
.github/workflows/test.yml |
Adds concurrency and pins just version; removes per-job permissions. |
.github/workflows/scorecard.yml |
Adds concurrency and replaces read-all with explicit permissions. |
.github/workflows/release.yml |
Tightens permissions, adjusts checkout credentials behavior, and pins just version. |
.github/workflows/lint.yml |
Adds concurrency and pins just version. |
Review details
Suppressed comments (3)
.github/workflows/release.yml:28
uses: $/.github/workflows/test.ymlis not a valid path for a local reusable workflow, so this job will fail to load. The called test workflow uploads artifacts, so the caller also needs to grantactions: write.
test:
permissions:
contents: read
id-token: write # to allow codecov oidc upload
uses: $/.github/workflows/test.yml
.github/workflows/release.yml:34
builduploads artifacts viaactions/upload-artifact, but its token permissions only includecontents: read. With explicit permissions set, artifact upload requires grantingactions: writefor this job.
build:
name: Build Package
runs-on: ubuntu-latest
permissions:
contents: read
.github/workflows/test.yml:195
coverage-combinedownloads artifacts viaactions/download-artifact, but its job-levelpermissionsomit theactionsscope (unspecified scopes becomenone). Grant at leastactions: readso artifact download works.
permissions:
contents: read
id-token: write # for oidc authentication to codecov
- Files reviewed: 7/8 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| lint: | ||
| permissions: | ||
| contents: read | ||
| actions: write | ||
| uses: ./.github/workflows/lint.yml | ||
| uses: $/.github/workflows/lint.yml |
| permissions: | ||
| security-events: write | ||
| id-token: write | ||
| security-events: write # allow uploading code scanning results | ||
| id-token: write # to allow OIDC authentication for publishing results to OpenSSF REST API |
| permissions: | ||
| contents: read | ||
|
|
||
|
|
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| security-events: write # for post to GH security |
No description provided.