ci: ship a native arm64 macOS binary - #53
Merged
Merged
Conversation
The only macOS artifact was x86_64-apple-darwin, so Apple Silicon users relied on Rosetta 2 to run it. Machines without Rosetta installed fail with "bad CPU type in executable". Add aarch64-apple-darwin to the release matrix so a native arm64 binary is published alongside the x86_64 one. Dropping the top-level `os` key is required, not cosmetic: with it, both macos-latest include entries would merge into the same job and the last `target` would win, silently replacing the x86_64 build instead of adding the arm64 one. With include-only, each entry expands to its own job. Closes #51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only macOS artifact was x86_64-apple-darwin, so Apple Silicon users relied on Rosetta 2 to run it. Machines without Rosetta installed fail with "bad CPU type in executable".
Add aarch64-apple-darwin to the release matrix so a native arm64 binary is published alongside the x86_64 one.
Dropping the top-level
oskey is required, not cosmetic: with it, both macos-latest include entries would merge into the same job and the lasttargetwould win, silently replacing the x86_64 build instead of adding the arm64 one. With include-only, each entry expands to its own job.Closes #51