Repository navigation
fix(DataTable): scroll wide tables inside the bordered container (#617) - #619
Draft
mathewtaylor wants to merge 1 commit into
Draft
mathewtaylor wants to merge 1 commit into
mathewtaylor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #617.
Problem
BbDataTablewraps the table in a bordered box with no overflow handling. When the table is wider than its parent, the last columns spill past the border and the surrounding card. Seen in the Admin Site blueprint's Members and Projects tables in the embedded preview (1280px window, about 770px of content width).Change
The table container now has
relative w-full overflow-x-auto, the same asBbDataGrid's container. A wide table scrolls sideways inside its border. Tables that fit look and behave as before.Tests
DataTableOverflowTestschecks the bordered container scrolls horizontally.DataTableOverflowTests,ApiSurfaceandDataViewSelectionTests: 7 passed in about 3s. No public API change.The other two overflows in #617 (Portfolio Budget and Choose Your Plan cards) are in the website repo and are fixed there separately.