fix(chart): default appVersion to post-auto-migrate buzz:main image - #5269
Open
Chessing234 wants to merge 3 commits into
Open
Chessing234 wants to merge 3 commits into
Chessing234 wants to merge 3 commits into
Conversation
Signed-off-by: Taksh <takshkothari09@gmail.com> Signed-off-by: Taksh <takshkothari09@gmail.com>
3 tasks
…-migrate-image Signed-off-by: Taksh <takshkothari09@gmail.com> # Conflicts: # deploy/charts/buzz/Chart.yaml # deploy/charts/buzz/values.yaml
🔐 Codex Security Review
|
Keep chart version 0.1.9 from main and the post-auto-migrate appVersion. Signed-off-by: Taksh <takshkothari09@gmail.com>
Contributor
Author
|
rebased onto main. kept chart 0.1.9 and appVersion main so auto-migrate still applies. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chart.appVersionnow defaults tomainso an emptyimage.tagrenders a post-auto-migrate image (BUZZ_AUTO_MIGRATEunderstands it). Compose already uses:main; the chart was still on0.1.0. (Add automatic database migrations #988, Chart 0.1.6 default image predates auto-migrate — out-of-box install crash-loops on a fresh external Postgres #2473)values.yamlimage.tag comment notes it must stay a post-auto-migrate image and to pin tosha-<7>/release tag in production.render_test.yaml: assert the default container image isghcr.io/block/buzz:main, and add security-default coverage that an unmodified render gates media GET/HEAD reads behind auth (BUZZ_REQUIRE_MEDIA_GET_AUTH=true) plus an explicit opt-out for dev/public deployments.Test plan
helm unittest deploy/charts/buzz -f deploy/charts/buzz/tests/render_test.yamlhelm template deploy/charts/buzz --set relayUrl=... --set ownerPubkey=...showsghcr.io/block/buzz:mainimage.tagpinned to a sha is unaffected