test(db): seed canonical large roster fixture - #6820
Draft
TheSentinel454 wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 25, 2026
Signed-off-by: tornquist <tornquist@squareup.com>
TheSentinel454
force-pushed
the
codex/issue-2-feed-roster-test-fixtures
branch
from
August 25, 2026 20:59
ed21d81 to
f18b0d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the 11,000-member feed mention-indexing regression fixture canonical under migration 0032 before the feed store extraction adds more ownership to
feed.rs.The test now seeds the matching
channel_membersrows and emits four-field kind-39002ptags with the authoritativememberrole. Its bind-parameter-cap assertion and 11,000-row scale are unchanged.Stack
codex/issue-2-feed-storeWhy separate
The existing ignored test is red against a freshly migrated current
main: migration 0032 rejects its legacy two-field roster tags beforeinsert_mentionsis exercised. The feed extraction PR is intended to move ownership without behavior changes, so this fixture correction is isolated in its own reviewable commit.Non-goals
Risk
Low and test-only. The fixture still creates 11,000 unique mentions, exceeds the single-statement bind cap at six binds per row, and asserts every mention is indexed.
Blox verification
Author workstation:
buzz-tornquist-issue-2-store-stack(2046520), native PostgreSQL 17.11.kind 39002 roster contains an invalid p tagconstraint.cargo fmt --all --check: passgit diff --check: passcargo clippy -p buzz-db --all-targets -- -D warnings: passfeed::tests::insert_mentions_indexes_rosters_past_bind_parameter_cap: passSuperseded pre-comment restack verification
PR #6700 merged before publication completed. This layer was restacked onto current main through the exact parent named above; the final cumulative tip is 2ddcc8a. Cumulative author gates passed: formatting and diff checks; buzz-db and buzz-relay all-target clippy with -D warnings; DB lib 111 passed / 200 ignored; ownership 22/22; observability 1/1; the full isolated PostgreSQL domain matrix; and relay lib 910 passed / 49 ignored.
Outcome
No actionable findings.
Reviewed the exact range
b87cec6d690119721e2ef3ac34e6ba57b41099c7..ed21d81e7fe1fa7606c6e67412b788cc6df12916on fresh Blox workstationbuzz-tornquist-pr-6820-final-review(ID2057635). The head is the direct child of the exact base. The test-only change seedschannel_memberswith the same 11,000 deterministic pubkeys emitted in four-field canonical rosterptags; it restores the large-roster bind-cap regression without changing production behavior.Verification
cargo fmt --all --check, range/worktreegit diff --check, and clean-tree checks passed.cargo clippy -p buzz-db --all-targets -- -D warningspassed.cargo test -p buzz-relay --lib --no-runpassed.feed::tests::insert_mentions_indexes_rosters_past_bind_parameter_cappassed with the current migrations.No code edits, commits, pushes, comments, or PR mutations were made. Buzz relay credentials were unavailable, so the private guide, ownership report, and workstream-channel updates were unavailable under the documented fallback. The workstation was deleted after artifacts were transferred.
Artifacts
4df56ed54eb6b5bba06fd26354e1937b40fddf785759dce475b10de6c67e4ad6931f2a86c0aaf54f51c1c70a6df0b359a759cdd40ceec22684628e679c72d806481b8bd4a98e1db2da8b2425f981109cbcaced6d11960083703ee1a4eed229acComment-addressed restack
Review follow-up on #6777 removed only the low-value replaceable ownership source test. This PR was restacked onto its rewritten parent; its production patch is unchanged.
19f2b86a063cecd1521eb003225ec76acb5d8bf3f18b0d3fdc45610d375637c2585d8ae5897627356fa2f104d42c6ba85bdf62e7ccb74ceaf4a84f67buzz-db/buzz-relayClippy; DB lib 111 passed / 200 ignored; ownership 21/21; observability 1/1; every moved PostgreSQL test; relay lib 910 passed / 49 ignored.buzz-dbClippy, current ownership/observability guards, feed tests (22 passed / 4 ignored), the moved large-roster PostgreSQL fixture, and relay compilation.