perf: make package-manager-delegated completions faster#142
Merged
Conversation
🦋 Changeset detectedLatest commit: ee0e5c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
AmirSa12
changed the title
AmirSa12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tab <pm> complete -- <cli> ...(thepnpm <cli> <TAB>path, plus the npm/yarn/bun equivalents) no longer parses<pm> --helpon the delegation path and launches the target CLI at most once instead of twice. On a real project this drops the tab overhead from ~0.5s to a single CLI launch.Also fixes a correctness gap where a cli installed only locally (reachable via
<pm> <cli>but not onPATH) could be detected yet return no completions: the fetch now tries the CLI directly first and falls back to running it through the package manager. The parsed<pm> --helpcommand tree is cached on disk (fingerprinted by the resolved executable, with a TTL) so package-manager-self completions stay fast too.