Sdk 6983 flush on signal v8 - #103
Merged
Merged
Conversation
Port of the v9 fix (SDK-6983-flush-on-signal): killed runs lose the logs.tar.gz upload because it only runs in launcher.onComplete. Rescue it from the exit-time detached cleanup (--uploadLogs, gated by a logsUploaded flag), snapshot funnelData credentials before fireFunnelRequest redacts them in place, and forward exitSignal/exitReason on StopBinSession so the binary stamps finished_metadata (v8 already had signal capture, user_killed funnel telemetry, and killSignal-aware stopBuildUpstream). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…aded on delivery Signal listeners suppress Node's default termination, so a hung shutdown never fires 'exit' and skips the cleanup rescue — force a 128+n exit after a grace window. Only mark logsUploaded when the server actually accepted the upload (a truthy response can still carry a non-success status). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hamza-browserstack
requested review from
anish353 and
yashdsaraf
and removed request for
a team
July 27, 2026 17:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.