Add file system access profile to execute response - #243
Conversation
EdSchouten
left a comment
EdSchouten
left a comment
There was a problem hiding this comment.
The problem is that the profile can become pretty big. I don't think it's a good idea to attach tens of kilobytes of data.
The recommended maximum size is 64 kB, so yes it is quite a bit of data. The goal is to get the access profile for a specific action. One could store the profile in FSAC for both the reduced action digest and the full action digest. That would though fill up the FSAC and there is race condition between execution and access if multiple actions are run in parallel. What about storing the profile in the CAS and reference it from the action result? Then it's just ~70 bytes of data. |
Yeah, that makes more sense, though I would recommend gating it by a configuration option. What are your thoughts on including it in |
|
Gating it by a configuration option seems very sensible. As for using the logs instead. We would need the profile to be easily accessible at runtime. |
We meant |
Currently bb-portal uses the latest file system access profile saved to the FSAC. This profile may differ from the profile produced by the action being viewed, for example when viewing old action results. With this change, action result contains its corresponding access profile.
Add file system access profile to execute response server logs and store it in content addressable storage when configured.
e20bd2d to
6c749c7
Compare
|
Has been rebased onto main and resubmitted with suggested changes. It now uses the Server Logs and CAS to log the file access profiles. |
| // Enables logging of generated file system access profiles. | ||
| // | ||
| // The profile digest is attached to the response Server Logs under | ||
| // "file-access-profile". The profile itself is also stored to |
There was a problem hiding this comment.
Can we call this file buildbarn.fsac.FileSystemAccessProfile, just like the fully-qualified name of the Protobuf message?
d03913a to
7d80446
Compare
EdSchouten
left a comment
EdSchouten
left a comment
There was a problem hiding this comment.
LGTM! Will merge if CI is happy.
3 participants
Currently bb-portal uses the latest file system access profile saved to the FSAC. This profile may differ from the profile produced by the action being viewed, for example when viewing old action results. With this change, action result contains its corresponding access profile.