Conversation
Member
|
Any type of file can currently exhaust the filesystem's hard link limit. Not just empty files. A change like this is therefore a workaround, which doesn't actually solve the problem at hand. Somebody sent out a PR to address this issue some time ago, but didn't respond to feedback I had left: #237. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch empty files directly instead of sharing one cached inode. Input trees with many empty files can otherwise exhaust the filesystem's hardlink limit; empty blobs do not need a download. This also avoids cache bookkeeping for those files.
Added coverage for repeated executable and non-executable empty files. The focused
TestHardlinkingFileFetchertest fails before the change and passes afterward in an isolated copy with generated mocks and a DarwinO_SEARCHdependency shim. The unmodified checkout's Go test command is blocked by those existing dependency/generation requirements.