guard guest cursor and delta in wasi-keyvalue in-memory store#13819
Open
netliomax25-code wants to merge 1 commit into
Open
guard guest cursor and delta in wasi-keyvalue in-memory store#13819netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list_keyscasts the guest-suppliedcursorwithas usizeand slices&keys[cursor..], so a cursor past the number of keys panics the host with an out-of-range slice, and the cast also truncates theu64on 32-bit hosts.incrementcomputescurrent_value + delta, which panics on overflow in debug builds and silently wraps to a smaller value in release, so the returned counter can go backwards.Clamped the cursor to
keys.len()(viatry_from+min) and switchedincrementtochecked_add, returning an error on overflow. Both values come straight from the guest, so the checks live in the callee. Added unit tests that panic on the current code and pass with the fix.