Repository navigation
fix(plugin-metro): watch project root when metro.config.js is missing - #735
Merged
Merged
Conversation
The no-config branch of loadMetroConfig returned the pre-built default config directly, so the project root was never added to watchFolders and bundle requests failed to resolve the entry file. Route that branch through metro-config's loadConfig so the project root is watched and CLI options are applied, and re-read the defaults from @react-native/metro-config so they include the framework defaults registered through setFrameworkDefaults.
|
@cpruijsen is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects without
metro.config.jsnow use Metro'sloadConfiginpackages/plugin-metro/src/lib/start/loadMetroConfig.ts.Both no-config paths apply CLI overrides and add
projectRoottowatchFolders, so Metro can findindex.js.The modern React Native path calls
getDefaultConfigaftersetFrameworkDefaultsregisters the framework defaults.The older API path retains its existing default merge.
Fixes #727.
Both new regression tests fail against the merge-base and pass with the fix.
A complete application or HTTP bundle test was not run.